github-actions[bot] commented on PR #22523: URL: https://github.com/apache/datafusion/pull/22523#issuecomment-4571696002
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 103.261s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v53.1.0 (baseline) Built [ 106.552s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.851s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 213.151s] datafusion Building datafusion-physical-plan v53.1.0 (current) Built [ 34.178s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.134s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 37.168s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.135s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.799s] 222 checks: 219 pass, 3 fail, 0 warn, 30 skip --- failure feature_missing: package feature removed or renamed --- Description: A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature. ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/feature_missing.ron Failed in: feature proto in the package's Cargo.toml --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/inherent_method_missing.ron Failed in: HashExpr::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0bb8e03b86530af65a4c830ec6e20c30806b5ecb/datafusion/physical-plan/src/joins/hash_join/partitioned_hash_eval.rs:237 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/trait_method_missing.ron Failed in: method downcast_delegate of trait ExecutionPlan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0bb8e03b86530af65a4c830ec6e20c30806b5ecb/datafusion/physical-plan/src/execution_plan.rs:138 method downcast_delegate of trait ExecutionPlan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/0bb8e03b86530af65a4c830ec6e20c30806b5ecb/datafusion/physical-plan/src/execution_plan.rs:138 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 74.245s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
