xiedeyantu commented on PR #22564: URL: https://github.com/apache/datafusion/pull/22564#issuecomment-4589443383
> @xiedeyantu Thanks for the iteration. There is still one correctness issue where the rewrites can bypass the runtime zero-value validation for non-literal expressions. @kosiew Thank you very much for your verification and review. I've reconsidered it now, and I think our simplify logic needs some adjustments. Perhaps we could intelligently support simplification in two modes: constant or a combination of constant and expression. So I've made some adjustments; could you please take another look and see if it's acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
