Omega359 commented on PR #22032: URL: https://github.com/apache/datafusion/pull/22032#issuecomment-4595589431
> Ok, sounds good -- was the idea that it was getting too complicated? Two things. First, I think I was trying to do too much for an initial PR. I was trying to support both sql and native benchmarks, supporting multi-character short versions of arguments (think -sf 10 for --scale-factor 10), and colouring output to mimic criterion's colours. I wasn't happy with how the selector code was turning out either. Second, and I do not want to imply anything here with you or anyone else specifically, but I am wanting to work on a project that has a faster turnaround on PR reviews. Closing this PR to focus on completing the core implementation for sql benchmarks and hooking it to bench.sh is my focus in my remaining work in this project near term. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
