Jefffrey commented on code in PR #22894:
URL: https://github.com/apache/datafusion/pull/22894#discussion_r3407113029
##########
.github/workflows/rust.yml:
##########
@@ -698,7 +741,8 @@ jobs:
config-docs-check:
name: check configs.md and ***_functions.md is up-to-date
- needs: linux-build-lib
+ needs: [linux-build-lib, detect-changes]
+ if: needs.detect-changes.outputs.has_code == 'true'
Review Comment:
could this mean if `configs.md` is manually changed without a code update we
could miss this? (or was that an existing issue?)
##########
.github/workflows/large_files.yml:
##########
@@ -23,6 +23,11 @@ concurrency:
on:
pull_request:
+ paths-ignore:
Review Comment:
maybe we keep this check even for doc files?
##########
.github/workflows/rust.yml:
##########
@@ -380,7 +408,8 @@ jobs:
# Run `cargo test doc` (test documentation examples)
linux-test-doc:
name: cargo test doc (amd64)
- needs: linux-build-lib
+ needs: [linux-build-lib, detect-changes]
+ if: needs.detect-changes.outputs.has_code == 'true'
Review Comment:
i think we run doc tests against the code in the md files too?
e.g.
https://github.com/apache/datafusion/blob/b8998c762bb864a9f3607a518384b03dcf40eb61/datafusion/core/src/lib.rs#L934-L940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
