sweb commented on PR #22892: URL: https://github.com/apache/datafusion/pull/22892#issuecomment-4699362515
> @sweb Thanks for tightening up the overflow handling here. I think there is one boundary case we need to fix before this lands: float values at exactly 2^64 can still slip through and saturate to u64::MAX instead of returning None. Thank you for your review. In addition to your requested changes, I noticed that PartialOrd (https://github.com/apache/datafusion/blob/main/datafusion/common/src/scalar/mod.rs#L621) only compares decimals on scales, so I added a commit (https://github.com/apache/datafusion/pull/22892/changes/d5f9c86381c3420d7f5ab3ca64c678c4edd6676b) that adjusts the handling of decimal to align with that. Happy to drop that again if this is not wanted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
