XiangpengHao commented on code in PR #11888:
URL: https://github.com/apache/datafusion/pull/11888#discussion_r1709554947
##########
datafusion/functions/src/string/initcap.rs:
##########
@@ -153,6 +168,34 @@ mod tests {
Utf8,
StringArray
);
+ test_function!(
+ InitcapFunc::new(),
+ &[ColumnarValue::Scalar(ScalarValue::Utf8View(Some(
+ "hi THOMAS".to_string()
+ )))],
+ Ok(Some("Hi Thomas")),
+ &str,
+ Utf8,
+ StringArray
+ );
+ test_function!(
+ InitcapFunc::new(),
+ &[ColumnarValue::Scalar(ScalarValue::Utf8View(Some(
+ "".to_string()
+ )))],
+ Ok(Some("")),
+ &str,
+ Utf8,
+ StringArray
+ );
+ test_function!(
+ InitcapFunc::new(),
+ &[ColumnarValue::Scalar(ScalarValue::Utf8View(None))],
+ Ok(None),
+ &str,
+ Utf8,
+ StringArray
+ );
Review Comment:
Can we add test cases where strings are longer than 12 bytes? That will
exercise the code path that read strings from buffer (instead of fully inlined).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
