alamb commented on code in PR #11828: URL: https://github.com/apache/datafusion/pull/11828#discussion_r1713874112
########## datafusion/common/src/stats.rs: ########## @@ -25,7 +25,7 @@ use arrow_schema::Schema; /// Represents a value with a degree of certainty. `Precision` is used to /// propagate information the precision of statistical values. -#[derive(Clone, PartialEq, Eq, Default)] +#[derive(Clone, PartialEq, Eq, Default, Copy)] Review Comment: 👍 -- I think that is basically what `#[derive(Debug)]` does in this case, which is kind of cook ########## datafusion/common/src/stats.rs: ########## @@ -25,7 +25,7 @@ use arrow_schema::Schema; /// Represents a value with a degree of certainty. `Precision` is used to /// propagate information the precision of statistical values. -#[derive(Clone, PartialEq, Eq, Default)] +#[derive(Clone, PartialEq, Eq, Default, Copy)] Review Comment: 👍 -- I think that is basically what `#[derive(Debug)]` does in this case, which is kind of cool -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
