ole-baranov commented on PR #26190: URL: https://github.com/apache/datafusion/pull/26190#issuecomment-6658344068
> @ole-baranov Can you share your benchmark figures? > > My tests do not show improved performance: > > ``` > group baseline changed > ----- -------- ------- > consume_wide_read/100 1.00 17.6±0.62µs ? ?/sec 1.04 18.3±0.25µs ? ?/sec > consume_wide_read/1000 1.00 219.1±6.51µs ? ?/sec 1.03 225.0±4.00µs ? ?/sec > consume_wide_read/10000 1.00 2.6±0.11ms ? ?/sec 1.03 2.7±0.05ms ? ?/sec > ``` I separated the commits to make testing more convenient. You can now run tests on these two commits separately. On my PC, I got these results: <before the change> consume_wide_read/100 time: [48.976 µs 49.349 µs 49.802 µs] consume_wide_read/1000 time: [2.7695 ms 2.7868 ms 2.8056 ms] consume_wide_read/10000 time: [239.59 ms 241.71 ms 243.91 ms] <after the one> consume_wide_read/100 time: [31.077 µs 31.262 µs 31.494 µs] consume_wide_read/1000 time: [465.22 µs 469.76 µs 475.38 µs] consume_wide_read/10000 time: [5.3852 ms 5.4306 ms 5.4836 ms] If -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
