andygrove opened a new pull request, #7512: URL: https://github.com/apache/datafusion-comet/pull/7512
## Which issue does this PR close? Backport of #6743 to `branch-1.2`. Closes #6742 on this branch. ## Rationale for this change When one argument of `arrays_overlap` is a scalar and the other is an array column, the native kernel returns row 0's result for the whole batch, or panics when the constant is the second argument (#6742, a correctness bug). `branch-1.2` has the same kernel. See #6743 for the full analysis. ## What changes are included in this PR? Cherry-pick of c39eb711e3 (`git cherry-pick -x`) with no conflicts and no adaptations. The diff against the source commit is identical apart from line numbers and blob hashes. `SparkArraysOverlap` keeps a scalar argument as a one-row list that every output row reads, and returns an array result when the other argument is an array. Other release branches: `branch-1.2` is the newest release branch, so there is no newer one to port to. Whether `branch-1.1` needs a backport is not part of this PR. ## How are these changes tested? On this branch, with JDK 17: the 30 `arrays_overlap` Rust unit tests in `datafusion-comet-spark-expr` pass, including the new ones, and `CometSqlFileTestSuite` `expressions/array/arrays_overlap.sql` passes against a native library built from this branch. The same SQL test fails against the `branch-1.2` native library without the fix, so the branch has the bug and the test catches it. I ran the default Spark profile only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
