andygrove opened a new pull request, #7524:
URL: https://github.com/apache/datafusion-comet/pull/7524

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   Small cleanup to remove dead code.
   
   ## What changes are included in this PR?
   
   Removes the unused osxcross cross-compile path from the release tooling. 
`MACOS_SDK` is never set in `dev/release/build-release-comet.sh`, so the Docker 
stage and the `HAS_OSXCROSS` blocks were never enabled.
   
   - the `with-macos-sdk-true` stage in `dev/release/comet-rm/Dockerfile`
   - the `MACOS_SDK` and `HAS_MACOS_SDK` handling in 
`dev/release/build-release-comet.sh`
   - the `HAS_OSXCROSS` blocks and the osxcross compiler calls in the 
`Makefile` (the Linux builds in those targets are unchanged)
   - `dev/cargo.config` and the `dev/release/comet-rm/workdir` entry in 
`.gitignore`
   
   ## How are these changes tested?
   
   No behavior change. `bash -n` and `make -n` pass for the touched script and 
targets. I did not build the release Docker image.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to