mbutrovich commented on code in PR #7516: URL: https://github.com/apache/datafusion-comet/pull/7516#discussion_r4484338261
########## docs/source/contributor-guide/ci.md: ########## @@ -158,7 +160,9 @@ Some things to know: `main` that adds nothing to upstream, such as syncing your fork, selects no suite, so it warms nothing, and a branch run rebuilds the native library. A run of the PR tier on a fork with cold caches took about an hour of wall time and 240 runner-minutes, of which the native build alone was - 23 minutes. The same run with warm caches took 50 minutes and 213 runner-minutes. + 23 minutes. The same run with warm caches took 50 minutes and 213 runner-minutes. Those figures + predate the Spark SQL and Iceberg suites joining the PR tier; a change that routes to them adds + their shards, which run in parallel with the Linux build's test matrix. Review Comment: Could we replace "Those figures predate..." with numbers from this PR's own [fork run](https://github.com/andygrove/datafusion-comet/actions/runs/42055098691), since it measures the new tier? It took 89 minutes of wall time and about 650 runner-minutes. The `PR Build (Linux)` jobs finished at 55 minutes and used 253 of those runner-minutes. The shards do run in parallel with the Linux matrix, but the Spark SQL job's `Build Native + JVM Test Classes` took 45 minutes before its shards started, so the run ended about 34 minutes after the Linux build. That wait is what a contributor iterating on the fork will notice. ```suggestion 23 minutes. The same run with warm caches took 50 minutes and 213 runner-minutes. A run that also routes to the Spark SQL and Iceberg suites took 89 minutes and about 650 runner-minutes. Their shards run in parallel with the Linux build's test matrix, but the Spark SQL job first builds its own native library and test classes, which took 45 minutes. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
