stuhood commented on code in PR #26593:
URL: https://github.com/apache/datafusion/pull/26593#discussion_r4484779746
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -217,6 +237,10 @@ pub struct RangePartitioning {
samples: Arc<[SplitPoint]>,
/// Effective boundaries for the current partition count.
split_points: Arc<[SplitPoint]>,
+ /// Inclusive start of the key space, in `ordering` order.
+ start_bound: Option<SplitPoint>,
+ /// Exclusive end of the key space, in `ordering` order.
+ end_bound: Option<SplitPoint>,
Review Comment:
> Then, strings split points will just never have a +-inf bound, there will
always be a value required, which at first sight sounds like a fair assumption.
Range will always be originated from leaf nodes, and I'd expect the leaf nodes
to always be able to provide an appropriate value for all split points in the
range.
What are the bounds for an empty partition? You'd have to invent something.
`min`/`max` involve a ton of special cases, but especially when they're
required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
