tlfua commented on PR #7457: URL: https://github.com/apache/datafusion-comet/pull/7457#issuecomment-6675413274
Thanks @coderfender, all four points were valid. Addressed in c181b6e8d (also merged the latest main): 1. Float/double `+`, `-`, `*`, negation and `abs` are now allowed in any eval mode. `Divide`, `IntegralDivide`, `Remainder` and `Pmod` stay excluded under ANSI, and integral types are unchanged. Added an ANSI test `ORDER BY a, d * 1.1D, d + 1, d - 1, -d, abs(d)` that stays native. 2. `GetStructField` is allowed (its child must also pass). Added a struct table with `ORDER BY a, s.x, s.y` staying native with ANSI on and off. 3. A cast from `DATE` to `STRING` is now treated as able to fail in every mode, with an `expect_fallback` test for `CAST(dt AS STRING)`. Reproduced locally (`Cast error: Failed to convert 100000000 to temporal for Date32` for `date_from_unix_date(100000000)`) and added it to https://github.com/apache/datafusion-comet/issues/7471#issuecomment-6674528964 . 4. The test comment now says the first key is evaluated for every row only when the input has at least two rows. Reproduced the single-row case locally (Spark returns the row, Comet raises `ARITHMETIC_OVERFLOW`) and filed https://github.com/apache/datafusion-comet/issues/7527 . Fork CI on the new head: **all jobs passed** ( https://github.com/tlfua/datafusion-comet/actions/runs/42145536518 ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
