paleolimbot opened a new issue, #27155:
URL: https://github.com/apache/datafusion/issues/27155
### Describe the bug
The logical an physical representations of `NOT` propagate metadata
differently.
I'm actually not sure which one is more correct...some metadata uses like
"sensor" or "where this value came from" probably are not lying after a NOT
operation; however, it's also a little like a function call which would discard
its output metadata.
### To Reproduce
```rust
#[test]
fn not_metadata_differs_between_logical_and_physical() -> Result<()> {
let schema = Schema::new(vec![Field::new("flag", DataType::Boolean,
false)]);
let df_schema = DFSchema::try_from(schema.clone())?;
let metadata = FieldMetadata::from(HashMap::from([(
"source".to_string(),
"input".to_string(),
)]));
let expr = Expr::Not(Box::new(
col("flag").alias_with_metadata("flag", Some(metadata)),
));
let logical_field = expr.to_field(&df_schema)?.1;
let physical_expr = create_physical_expr(
&expr,
&df_schema,
&ExecutionProps::new(),
&PhysicalPlanningContext::default(),
)?;
let physical_field = physical_expr.return_field(&schema)?;
// Logical NOT creates a metadata-free Boolean field.
assert_eq!(logical_field.metadata().get("source"), None);
// Physical NotExpr forwards its child's field metadata.
assert_eq!(
physical_field.metadata().get("source").map(String::as_str),
Some("input")
);
Ok(())
}
```
### Expected behavior
I'd expect the result to match
### Additional context
_No response_
### Willingness to contribute
I would like to contribute a fix for this bug, but request guidance from the
DataFusion community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
