comphead commented on code in PR #7336: URL: https://github.com/apache/datafusion-comet/pull/7336#discussion_r4470288235
########## docs/source/user-guide/latest/migration-guide.md: ########## @@ -57,6 +57,15 @@ Treat setting one of these keys as a temporary measure. If you find you cannot s legacy behavior, please open an issue describing your use case so it can be considered before the key is removed. +## Upgrading to Comet 1.3.0 + +### Shuffle Manager Set by the Plugin on Spark 4.0 and Later Review Comment: The guide's introduction says every behavior change below names a `spark.comet.legacy.*` key, and the 1.2.0 section says up front when none is needed. This entry names no key. Running an application in Comet instead of Spark is the "which operators run natively" kind of change that the introduction excludes, so could the 1.3.0 section say it needs no legacy key, as 1.2.0 does? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
