zhuqi-lucas commented on issue #26481: URL: https://github.com/apache/datafusion/issues/26481#issuecomment-6688970894
Thanks @jayzhan211, this makes sense to me. Making each rule correct in any position is a clearer goal than the split, and it can land one rule at a time. Happy to help review the PoC, and I can take `PushdownSort` if that helps. One thing to watch is planning cost: if rules have to be safe in any position, some work may end up repeated (re-enforcing requirements, re-running passes, as in #25355). A plan fingerprint to skip a rule or pass when its input has not changed, along the lines of #25356, could keep that cheap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
