paleolimbot commented on code in PR #27143: URL: https://github.com/apache/datafusion/pull/27143#discussion_r4489527581
########## datafusion/sqllogictest/test_files/metadata.slt: ########## @@ -687,6 +687,105 @@ NULL l_bar baz +# CASE merges the metadata of its value branches with the same rules as +# coalesce: the earlier branch wins for each key, and an extension name is kept +# together with its parameters. The operand of a simple CASE and the WHEN +# conditions do not contribute. +query TTT +select + arrow_metadata(case when id > 1 then name else l_name end, 'metadata_key'), + arrow_metadata(case id when 1 then name else l_name end, 'metadata_key'), + arrow_metadata( + case when id > 1 + then with_metadata(name, 'ARROW:extension:name', 'a.type') + else with_metadata(l_name, 'ARROW:extension:name', 'a.type') end, Review Comment: I believe that UUID and JSON extension types are not built in, and I wonder if these SLT tests can be made any less verbose by using them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
