Rich-T-kid commented on PR #26816:
URL: https://github.com/apache/datafusion/pull/26816#issuecomment-6702181734

   addressing the comments now!
   
   >Since this PR isn't ready yet, I'd prefer to move forward with 
https://github.com/apache/datafusion/pull/26703 first, though there may still 
be some things left to do there.
   
   I actually think we should go with both. I think for repartionExec we should 
cache the value computation as that plays into the strengths of dictionary 
encoding and then for other portions of the code base like `regex` or 'like' or 
specefic functions like that we should go with the trimming case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to