dwsmith1983 opened a new pull request, #7556: URL: https://github.com/apache/datafusion-comet/pull/7556
## Which issue does this PR close? Part of #7128. This is the first of four pull requests for #7128, each covering one area. They build on #7127, which adds the URL redaction helpers they use, so #7127 merges first. Suggested order after it: 1. This one: object store setup and its error messages. 2. The Parquet writer's URL errors, plan display and debug log. 3. Native Delta's URL display and deletion vector errors. 4. The rejected path reason on the JVM side, which closes #7128. They target `main`, so until #7127 merges each one also shows its commits. ## Rationale for this change Several native object store paths print the whole URL in an error message or keep it in a stored value. A URL can carry a password in its userinfo or a SAS token or signature in its query string, so those errors put secrets in task failures and logs. object_store's own errors quote whatever URL they are handed, so passing it the raw URL is enough to leak. ## What changes are included in this PR? - The fallthrough to object_store's `parse_url` hands it the URL without userinfo or query. An `az` URL keeps its username, which object_store reads as the container. - The S3 store parses a URL without credentials, the S3 template stores one, and its "not S3" error names only the scheme. - The parse and missing bucket errors for `blob` style aliases no longer quote the URL. - A `hdfs` URL with no host reports its scheme instead of the whole URL. None of these stores reads the password or the query from the URL, so only the messages change. ## How are these changes tested? Native tests build each URL with a password, a username and a signature query, then check that none of them appears in the error or stored URL while the host or scheme does. One covers the HTTP store's request error, and one checks that an `az` URL keeps its container. Each test fails on the base branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
