alamb commented on code in PR #12522:
URL: https://github.com/apache/datafusion/pull/12522#discussion_r1765223913
##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -855,24 +850,18 @@ fn build_recover_project_plan(
Projection::try_new(col_exprs,
Arc::new(input)).map(LogicalPlan::Projection)
}
-fn extract_expressions(
- expr: &Expr,
- schema: &DFSchema,
- result: &mut Vec<Expr>,
-) -> Result<()> {
+fn extract_expressions(expr: &Expr, result: &mut Vec<Expr>) {
Review Comment:
I may have missed it, but all the usages of extract_expressions seem to be
for a new empty vec
So this could potentially be simplified even further (perhaps as a follow on
PR)
```rust
fn extract_expressions(expr: &Expr) -> Vec<Expr> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
