notfilippo commented on PR #12536: URL: https://github.com/apache/datafusion/pull/12536#issuecomment-2363233395
> Can you elaborate what this is needed for? @findepi -- `DataType` in Scalar is needed as a way to retain the physical type that the ScalarValues represents. That knowledge will be used when creating arrays from scalar types. It comes especially useful when converting a vector of scalars into an array of the correct physical type. You can find some more context here: https://github.com/apache/datafusion/pull/11978#issuecomment-2293837444 As @jayzhan211 mentions in https://github.com/apache/datafusion/pull/11978#issuecomment-2294518747 and https://github.com/apache/datafusion/pull/11978#issuecomment-2297870220 it's a step towards the goal but it does not represent the full decoupling of physical and logical types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
