berkaysynnada opened a new pull request, #12559:
URL: https://github.com/apache/datafusion/pull/12559
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example Closes #123
indicates that this PR will close issue #123.
-->
Closes #12558.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
HashJoinExec and NestedLoopJoinExec maintains the order of right child. If a
SortExec appears at the top of these joins, now it can be pushed down through
its right child if all the requirements come from right child.
pushdown_requirement_to_children() logic was problematic for join operators.
It is generalized now for any kind of operators if it falls to else{} block.
Nested brought a bug
HashJoin cannot pushdown
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
`pushdown_requirement_to_children()` function in `sort_pushdown.rs` is
responsible for determining whether a sort operation can be pushed down over an
operator, and if so, how the requirements are propagated. While most operators
are handled properly, the mentioned operators (`HashJoinExec` and
`NestedLoopJoinExec`) and other newly added operators may encounter issues due
to missing index updates and the not utilizing the generic maintains flags. Now
they are handled via `handle_custom_pushdown()`
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the api change
label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
