alamb commented on code in PR #12632:
URL: https://github.com/apache/datafusion/pull/12632#discussion_r1777693960
##########
datafusion/core/src/catalog_common/information_schema.rs:
##########
@@ -70,20 +71,11 @@ impl InformationSchemaProvider {
}
}
-#[derive(Clone)]
+#[derive(Clone, Debug)]
struct InformationSchemaConfig {
catalog_list: Arc<dyn CatalogProviderList>,
}
-impl Debug for InformationSchemaConfig {
- fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result {
- f.debug_struct("InformationSchemaConfig")
- // TODO it would be great to print the catalog list here
Review Comment:
🎉
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -177,23 +177,23 @@ impl Debug for SessionState {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_struct("SessionState")
.field("session_id", &self.session_id)
- .field("analyzer", &"...")
+ .field("config", &self.config)
Review Comment:
I wonder if we could simply `#derive(Debug)` for SessionState now?
And perhaps we could provide a `impl Display for SessionState` that had a
more readable format (like that shows session_id and deviation from default
configuration, for example 🤔 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
