findepi commented on PR #12890: URL: https://github.com/apache/datafusion/pull/12890#issuecomment-2408688447
Makes sense to me! If this is an already established knowledge that replacing `make_function_scalar_inputs_return_type` with `unary` is an improvement, I don't see a need to benchmark this every time separately. IMO we could just do this change everywhere where the code pattern is same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
