epsio-banay commented on code in PR #12943:
URL: https://github.com/apache/datafusion/pull/12943#discussion_r1818028101
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -628,6 +627,103 @@ fn infer_join_predicates(
.collect::<Result<Vec<_>>>()
}
+/// Check whether the given expression depends only on the columns in the
given schema.
+/// Meaning for a certain
Review Comment:
Hey,
I agree that this code is a duplicate and it should be a common function,
however `expr_applicable_for_cols` uses column names as argument, so in case we
have two columns with the same name but with different qualifiers, the function
will produce incorrect result.
IMO we would need to dig into `expr_applicable_for_cols`'s usage (there's
only one) and understand if it should be fixed. Unfortunately I won't have much
time to do it in the coming weeks.
In the mean time I moved this function to be a method of expr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
