alamb commented on code in PR #13502:
URL: https://github.com/apache/datafusion/pull/13502#discussion_r1850878413
##########
datafusion/functions/src/crypto/md5.rs:
##########
@@ -64,11 +64,11 @@ impl ScalarUDFImpl for Md5Func {
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
use DataType::*;
Ok(match &arg_types[0] {
- LargeUtf8 | LargeBinary => LargeUtf8,
+ LargeUtf8 | LargeBinary => Utf8,
Review Comment:
Maybe as a follow on it should really be LargeUtf8 but then we would have to
change the function I suppose
##########
datafusion/functions/src/crypto/md5.rs:
##########
@@ -64,11 +64,11 @@ impl ScalarUDFImpl for Md5Func {
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
use DataType::*;
Ok(match &arg_types[0] {
- LargeUtf8 | LargeBinary => LargeUtf8,
+ LargeUtf8 | LargeBinary => Utf8,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
