mertak-synnada commented on code in PR #14121:
URL: https://github.com/apache/datafusion/pull/14121#discussion_r1914428755
##########
datafusion/core/src/datasource/physical_plan/mod.rs:
##########
@@ -90,13 +109,23 @@ pub struct FileSinkConfig {
pub insert_op: InsertOp,
/// Controls whether partition columns are kept for the file
pub keep_partition_by_columns: bool,
+ /// File extension without a dot(.)
+ pub file_extension: String,
Review Comment:
`FileSinkConfig` did not carry any file-type related information before but
giving file_extension explicitly to the helper functions also bothered us.
That's why we've added this to the `FileSinkConfig`. Could not get a consensus
on keeping FileSinkConfig file-type agnostic or adding this please let us know
what do you think :) @alamb
CC: @berkaysynnada @ozankabak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
