comphead commented on code in PR #14127:
URL: https://github.com/apache/datafusion/pull/14127#discussion_r1915584242
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -2646,3 +2646,58 @@ async fn boolean_dictionary_as_filter() {
assert_batches_eq!(expected, &result_df.collect().await.unwrap());
}
+
+#[tokio::test]
Review Comment:
Thanks @jonahgao, nice PR, I would also add a test with some edge cases like
nested alias, empty string alias
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
