alamb opened a new pull request, #14167:
URL: https://github.com/apache/datafusion/pull/14167

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes https://github.com/apache/datafusion/issues/14166
   
   ## Rationale for this change
   See https://github.com/apache/datafusion/issues/14166
   
   TLDR is I don't want to have to remember to check all the variants of 
ScalarValue that can contain a string
   
   ## What changes are included in this PR?
   
   1. Add `ScalarValue::try_as_str` to get str value from logical strings
   2. Add docs/examples
   3. Update some of the code in DataFusion to use this new API
   
   ## Are these changes tested?
   
   yes, by doc tests and examples
   
   ## Are there any user-facing changes?
   there is a new API but all existing APIs still work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to