alamb commented on code in PR #14126:
URL: https://github.com/apache/datafusion/pull/14126#discussion_r1920352694
##########
datafusion/expr-common/src/interval_arithmetic.rs:
##########
@@ -76,6 +76,14 @@ macro_rules! get_extreme_value {
DataType::Interval(IntervalUnit::MonthDayNano) => {
ScalarValue::IntervalMonthDayNano(Some(IntervalMonthDayNano::$extreme))
}
+ DataType::Decimal128(precision, scale) => {
+ ScalarValue::Decimal128(Some(i128::$extreme), *precision,
*scale)
Review Comment:
> sadly the decimal 256 version is not public 😢 let me find a workaround
I recommend
1. copy/pasting the value into DataFusion for now
2. File a ticket in arrow-rs to make it public (or maybe even a PR!)
3. leave a comment next to the copy in DataFUsion referencing the upstream
ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
