ahmed-mez commented on code in PR #16152:
URL: https://github.com/apache/datafusion/pull/16152#discussion_r2102871203
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -529,7 +529,12 @@ impl GroupedHashAggregateStream {
})
.collect();
- let name = format!("GroupedHashAggregateStream[{partition}]");
+ let agg_fn_names = aggregate_exprs
+ .iter()
+ .map(|expr| expr.name().to_string())
Review Comment:
Good catch, thanks! I agree `human_display` seems more adapted to the
current use-case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
