xudong963 commented on code in PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#discussion_r2105699811
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -178,7 +185,7 @@ mod tests {
source = source.with_bloom_filter_on_read(false);
}
- source.with_schema(Arc::clone(&file_schema))
+ source.with_schema(Arc::clone(&table_schema))
Review Comment:
👍 , I didn't notice here before
```rust
pub struct ParquetSource {
/// Options for reading Parquet files
pub(crate) table_parquet_options: TableParquetOptions,
/// Optional metrics
pub(crate) metrics: ExecutionPlanMetricsSet,
/// The schema of the file.
/// In particular, this is the schema of the table without partition
columns,
/// *not* the physical schema of the file.
pub(crate) file_schema: Option<SchemaRef>,
```
Maybe we can change the `file_schema` name to a clearer name later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
