2010YOUY01 opened a new pull request, #16880:
URL: https://github.com/apache/datafusion/pull/16880
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
My local dev branch triggers a heisenbug:
```
cargo test --features backtrace --test sqllogictests
```
The error message said the csv file (the temporary file created inside .slt)
does not exist
```
1. query failed: DataFusion error: Internal error: Error encountered while
finalizing writes! Partial results may have been written to ObjectStore!.
This issue was likely caused by a bug in DataFusion's code. Please help us
to resolve this by filing a bug report in our issue tracker:
https://github.com/apache/datafusion/issues
[SQL] COPY (values (1), (2), (3), (4), (5)) TO
'test_files/scratch/limit/t1.csv'
STORED AS CSV
at
/Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/joins.slt:4259
2. query failed: DataFusion error: Object Store error: Object at location
/Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/scratch/limit/t1.csv
not found: No such file or directory (os error 2)
[SQL] select * from t1 LEFT JOIN t2 ON t1.a = t2.b LIMIT 2;
at
/Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/joins.slt:4281
3. query failed: DataFusion error: Object Store error: Object at location
/Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/scratch/limit/t1.csv
not found: No such file or directory (os error 2)
[SQL] select * from t1 LEFT JOIN t2 ON t1.a = t2.b LIMIT 2;
at
/Users/yongting/Code/datafusion/datafusion/sqllogictest/test_files/joins.slt:4289
...
```
My guess for the reason is, the test in `joins.slt` is creating tmp file
under `limit/` folder, and the `limit.slt` test file will also write to the
same folder.
My local change triggered a specific timing that caused two test runners to
write to the same scratch folder concurrently, resulting in a collision. I
tried using a separate scratch subfolder, and the error went away.
(Even if that's not the root cause, I believe having each test file use a
scratch folder with the same name is a more idiomatic approach.)
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Change the scratch test file created by `joins.slt` to be under `joins/`
subfolder, to avoid such collision.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
