alamb opened a new issue, #16896: URL: https://github.com/apache/datafusion/issues/16896
@findepi noted that `AsyncScalarUDFImpl::invoke_async_with_args` is inconsistent with `ScalarUDFImpl::invoke_async_with_args` Here is `AsyncScalarUDFImpl::invoke_async_with_args`: https://github.com/apache/datafusion/blob/dbc03fa4f6d47c8f3b97f3a3d979945b2b7ccce7/datafusion/expr/src/async_udf.rs#L49-L54 `ScalarUDFImpl::invoke_with_args` https://github.com/apache/datafusion/blob/d553ffdff88ff62fc0cd29d5bb924771e7c6c904/datafusion/expr/src/udf.rs#L557 Specifically I think they should both return a `ColumnarValue ` Why ArrayRef instead of ColumnarValue? Is this inconsistency warranted? _Originally posted by @findepi in https://github.com/apache/datafusion/pull/16846#discussion_r2221434436_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
