comphead commented on code in PR #2265:
URL: https://github.com/apache/datafusion-comet/pull/2265#discussion_r2312610324
##########
spark/src/main/scala/org/apache/comet/serde/predicates.scala:
##########
@@ -21,13 +21,109 @@ package org.apache.comet.serde
import scala.collection.JavaConverters._
-import org.apache.spark.sql.catalyst.expressions.{Attribute, Expression,
GreaterThan, GreaterThanOrEqual, In, InSet, IsNaN, IsNotNull, IsNull, LessThan,
LessThanOrEqual, Literal, Not}
+import org.apache.spark.sql.catalyst.expressions.{And, Attribute,
EqualNullSafe, EqualTo, Expression, GreaterThan, GreaterThanOrEqual, In, InSet,
IsNaN, IsNotNull, IsNull, LessThan, LessThanOrEqual, Literal, Not, Or}
import org.apache.spark.sql.types.BooleanType
import org.apache.comet.CometSparkSessionExtensions.withInfo
import org.apache.comet.serde.ExprOuterClass.Expr
import org.apache.comet.serde.QueryPlanSerde._
+object CometNot extends CometExpressionSerde[Not] {
Review Comment:
this is nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
