KR-bluejay commented on issue #1219:
URL:
https://github.com/apache/datafusion-ballista/issues/1219#issuecomment-3264755833
Hi, @milenkovicm
I have implemented the pull-based cleanup, but I’m not sure about two things:
(Currently, the PR is still in draft mode. #1314)
1. **Tests**
The scheduler keeps the cleanup job list, and the executors fetch it via
`poll_work`.
I’m not sure how to properly test this flow.
Do you have any recommendations or existing test patterns I should follow?
2. **User-facing changes**
As far as I can see, this only adds values during `poll_work` from
scheduler to executor.
I don’t think there are any user-facing changes.
Could you confirm if that’s correct?
Thanks in advance for your advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
