comphead commented on code in PR #17459:
URL: https://github.com/apache/datafusion/pull/17459#discussion_r2330806574


##########
datafusion/sql/src/statement.rs:
##########
@@ -2024,9 +2024,9 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
             let mut value_indices = vec![None; table_schema.fields().len()];
             let fields = columns
                 .into_iter()
-                .map(|c| self.ident_normalizer.normalize(c))
                 .enumerate()
                 .map(|(i, c)| {
+                    let c = self.ident_normalizer.normalize(c);

Review Comment:
   it was 2 `map` before, I hope rustc is smart enough to merge them in 
runtime, but in this case it slighlty more readable as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to