kylebarron commented on code in PR #1241:
URL:
https://github.com/apache/datafusion-python/pull/1241#discussion_r2355804076
##########
python/datafusion/dataframe.py:
##########
@@ -370,6 +375,39 @@ def schema(self) -> pa.Schema:
Describing schema of the DataFrame
"""
return self.df.schema()
+
+ def to_batches(self) -> list[pa.RecordBatch]:
+ """Convert DataFrame to list of RecordBatches."""
+ return self.collect() # delegate to existing method
Review Comment:
> Now if there is a way we can remove this dependency and it doesn't break
existing workflows
I think the straightforward way to do that is to remove pyarrow as a
required dependency and error if it's not installed. But a separate question is
whether we should be adding _new methods_ that explicitly depend on pyarrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
