alamb commented on PR #19064: URL: https://github.com/apache/datafusion/pull/19064#issuecomment-3648048531
> The problem I see with this is that (1) there's obvious benefit to supporting more things in the future and (2) @zhuqi-lucas already has a PR open to do so. So if we stick to a narrower API we're bound to break it in ~ days. It's also nice to have the consistency of API both across the sort pushdown stack but also with projection and filter pushdown. To be clear, I am only talking about `DataSource` (I do think pushdown_sort makes sense for ExecutionPlan and FileScanConfig) @zhuqi-lucas 's other PR shouldn't be using sort expressions in the parquet source, I don't think -- it should just reverse them all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
