pmallex opened a new pull request, #19339: URL: https://github.com/apache/datafusion/pull/19339
## Which issue does this PR close? Closes #19249 ## Rationale for this change SQL allows for column names to begin with `@`, so long as the identifier is quoted. For example, `SELECT "@column" FROM table`. Both PostgreSQL and MySQL allow for this at least. The existing SQL parser treats these column names as placeholder variables, because it does not check if the identifier is quoted. This change corrects that behavior. ## What changes are included in this PR? sql/src/expr/identifier.rs - fix to check if identifiers are quoted sql/tests/common/mod.rs - new test table sql/tests/sql_integration.rs - unit test ## Are these changes tested? Yes, `test_parse_quoted_column_name_with_at_sign` unit test was added to verify quoted column names beginning with `@` are treated as column names instead of placeholder variables. ## Are there any user-facing changes? It's possible users are relying on the existing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
