ujjwaltwri commented on code in PR #19189:
URL: https://github.com/apache/datafusion/pull/19189#discussion_r2620471424
##########
datafusion/functions/src/string/concat.rs:
##########
@@ -79,7 +81,31 @@ impl ScalarUDFImpl for ConcatFunc {
fn as_any(&self) -> &dyn Any {
self
}
+ fn return_field_from_args(
Review Comment:
Thanks for pointing this out.
I’ve reverted the changes to datafusion/functions/src/string/concat.rs —
this PR now only modifies the Spark implementation under
datafusion/spark/src/function/string/concat.rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]