nuno-faria commented on code in PR #19316:
URL: https://github.com/apache/datafusion/pull/19316#discussion_r2620608725
##########
datafusion/physical-plan/src/analyze.rs:
##########
@@ -271,19 +328,41 @@ fn create_output_batch(
.map_err(DataFusionError::from)
}
+fn export_auto_explain(batch: RecordBatch, output: &str) -> Result<()> {
+ let fd: &mut dyn Write = match output {
+ "stdout" => &mut io::stdout(),
+ "stderr" => &mut io::stderr(),
+ _ => &mut OpenOptions::new().create(true).append(true).open(output)?,
Review Comment:
> Does this need any kind of validation of the file location ?
> Or it is left to the developer/admin to make sure it is a safe place ?
I think it's better to leave this to the user (either way, an error is
returned).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
