martin-g commented on code in PR #19345: URL: https://github.com/apache/datafusion/pull/19345#discussion_r2622653047
########## datafusion-examples/examples/custom_data_source/default_column_values.rs: ########## Review Comment: Should this line be removed/edited ? https://github.com/apache/datafusion/pull/19345/changes#diff-dd8ef704e14ac0794362f6dd9b356468e45d3ea33be15708ec2f339b5a0fdb72R67 says that projection expressions (note: expressions vs. columns) is also covered by PhysicalExprAdapter ########## docs/source/library-user-guide/upgrading.md: ########## @@ -490,6 +490,24 @@ If you were using a custom `SchemaAdapterFactory` for schema adaptation (e.g., d See the [default column values example](https://github.com/apache/datafusion/blob/main/datafusion-examples/examples/custom_data_source/default_column_values.rs) for how to implement a custom `PhysicalExprAdapterFactory`. +### `SchemaAdapter` and `SchemaAdapterFactory` completely removed Review Comment: This new paragraph overlaps with the previous one - `### `SchemaAdapterFactory` Fully Removed from Parquet` Maybe they should be merged into one ?! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
