iffyio commented on code in PR #2130:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2130#discussion_r2623064312
##########
tests/sqlparser_oracle.rs:
##########
@@ -33,6 +34,15 @@ fn oracle() -> TestedDialects {
TestedDialects::new(vec![Box::new(OracleDialect)])
}
+/// Convenience constructor for [QuoteDelimitedstring].
+fn qds(start_quote: char, value: &'static str, end_quote: char) ->
QuoteDelimitedString {
Review Comment:
```suggestion
fn quote_delimited_string(start_quote: char, value: &'static str, end_quote:
char) -> QuoteDelimitedString {
```
##########
tests/sqlparser_oracle.rs:
##########
@@ -103,3 +113,192 @@ fn plusminus_have_same_precedence_as_strconcat() {
}
);
}
+
+#[test]
+fn parse_quote_delimited_string() {
+ let sql = "SELECT Q'.abc.', \
+ Q'Xab'cX', \
+ Q'|abc'''|', \
+ Q'{abc}d}', \
+ Q'[]abc[]', \
+ Q'<a'bc>', \
+ Q'<<<a'bc>', \
+ Q'('abc'('abc)', \
+ Q'(abc'def))', \
+ Q'(abc'def)))' \
+ FROM dual";
+ let select = oracle().verified_only_select(sql);
Review Comment:
can we change the dialect being tested to use the dialect method?
```rust
let dialect = all_dialects_where(|d| d.supports_quote_delimited_string());
dialect.verified_only_select(sql);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
