comphead commented on code in PR #2902:
URL: https://github.com/apache/datafusion-comet/pull/2902#discussion_r2624174728
##########
spark/src/test/scala/org/apache/spark/sql/benchmark/CometShuffleBenchmark.scala:
##########
@@ -490,7 +497,80 @@ object CometShuffleBenchmark extends CometBenchmarkBase {
}
}
+ def shuffleDeeplyNestedBenchmark(
+ name: String,
+ filename: String,
+ numRows: Int,
+ partitionNum: Int): Unit = {
+ val benchmark =
+ new Benchmark(s"Shuffle with nested schema ($name)", numRows, output =
output)
+ val df = spark.read.parquet(filename)
+ withTempTable("deeplyNestedTable") {
+ df.createOrReplaceTempView("deeplyNestedTable")
+ val sql = "select * from deeplyNestedTable"
+
+ benchmark.addCase("Spark") { _ =>
+ spark
+ .sql(sql)
+ .repartition(partitionNum)
+ .noop()
+ }
+
+ benchmark.addCase("Comet (Spark Shuffle)") { _ =>
+ withSQLConf(
+ CometConf.COMET_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "false") {
+ spark
+ .sql(sql)
+ .repartition(partitionNum)
+ .noop()
+ }
+ }
+
+ for (shuffle <- Seq("jvm", "native")) {
+ benchmark.addCase(s"Comet ($shuffle Shuffle)") { _ =>
+ withSQLConf(
+ CometConf.COMET_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
+ CometConf.COMET_SHUFFLE_MODE.key -> shuffle) {
+ spark
+ .sql(sql)
+ .repartition(partitionNum)
+ .noop()
+ }
+ }
+ }
+
+ benchmark.run()
+ }
+ }
+
override def runCometBenchmark(mainArgs: Array[String]): Unit = {
+
+ // nested type shuffle
+ val numRows = 1000
+ for (generateArray <- Seq(true, false)) {
Review Comment:
should map be here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
