pepijnve commented on code in PR #19287:
URL: https://github.com/apache/datafusion/pull/19287#discussion_r2625134013
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -1127,16 +1159,31 @@ impl GroupedHashAggregateStream {
self.clear_shrink(&RecordBatch::new_empty(s));
}
+ /// Determines if groups are currently available to emit
+ fn can_emit(&self) -> bool {
+ match self.oom_mode {
Review Comment:
Not sure what to call this. It's used to check, when an OOM situation has
occurred after processing a batch, if emitting completed groups is way to get
out of the OOM situation or not.
`can_emit_early_on_oom` is "can I forcibly push out group values even though
they're not complete".
`can_emit` is "are there complete groups ready that can be pushed out"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
