Omega359 commented on code in PR #19078:
URL: https://github.com/apache/datafusion/pull/19078#discussion_r2627301429
##########
datafusion/functions/src/datetime/to_timestamp.rs:
##########
@@ -988,13 +1605,21 @@ mod tests {
}
#[test]
- fn test_tz() {
+ fn test_no_tz() {
Review Comment:
Should never happen, and that order of calls would most certainly break
because the return_type() function would return a type that doesn't match the
invoke_with_args types if the tz is set to anything but the default. It's also
somewhat covered by the slt tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
