erratic-pattern commented on PR #19360: URL: https://github.com/apache/datafusion/pull/19360#issuecomment-3665650741
If you are seeing passing on the repro tests, you may need to adjust the reproducer depending on local environment due to timing issues. Some things I found that needed to be adjusted if the query is completing too quickly. - if the query finishes before the initial 250ms sleep it won't hang on the task cancellation. This initial sleep is needed to ensure the task enters the JoinExec stream before `handle.abort()` is called. A smaller initial sleep will fix this. - If the query finishes before the 5 second timeout the repro tests will pass despite not cancelling properly. In this case the query is completing normally within the 5 second window, but ignoring the cancellation. Maybe the repro needs a better way to indicate this by checking whether the query succeeded. To fix this, bump the number of rows OR reduce the timeout to ensure that the query execution time takes longer than the timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
