coderfender commented on code in PR #2925:
URL: https://github.com/apache/datafusion-comet/pull/2925#discussion_r2641058678
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -684,21 +683,88 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+// This is to pass the first `all cast combinations are covered`
ignore("cast StringType to DecimalType(10,2)") {
Review Comment:
@andygrove this test cant be enabled given that we are still marking the
casts as incompatible . However I added the same tests (with a different name
to make sure they pass) . Enabling this test will fail 'all cast combinations
are covered'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
