Jefffrey commented on code in PR #19603:
URL: https://github.com/apache/datafusion/pull/19603#discussion_r2657079126
##########
datafusion/functions-nested/src/make_array.rs:
##########
@@ -80,10 +79,7 @@ impl Default for MakeArray {
impl MakeArray {
pub fn new() -> Self {
Self {
- signature: Signature::one_of(
- vec![TypeSignature::Nullary, TypeSignature::UserDefined],
Review Comment:
I don't really like the idea of having `UserDefined` nested within a `OneOf`
signature, so amending some functions which are doing this. Ideally a function
declaring `UserDefined` should handle all of its coercion logic itself, instead
of mixing this custom logic with the other signature API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
